Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cage recreate #70

Merged
merged 11 commits into from
May 29, 2024
Merged

feat: cage recreate #70

merged 11 commits into from
May 29, 2024

Conversation

keroxp
Copy link
Member

@keroxp keroxp commented May 28, 2024 •
edited
Loading

  • added new cage recreate command
  • added a confirmation prompt for all commands when they run in the local environment
  • added --ci global option that refers CI environment variable
  • bumped aws-sdk-go and other deps
  • rewrote test codes using cage_test package
  • use xerrors for making errors

@keroxp keroxp marked this pull request as ready for review May 28, 2024 11:21
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.49798% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 77.83%. Comparing base (0d93d9b) to head (089c985).
Report is 3 commits behind head on main.

Files Patch % Lines
rollout.go 86.95% 4 Missing and 5 partials ⚠️
env.go 50.00% 3 Missing ⚠️
up.go 70.00% 1 Missing and 2 partials ⚠️
util.go 72.72% 1 Missing and 2 partials ⚠️
time.go 50.00% 2 Missing ⚠️
run.go 96.96% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   70.60%   77.83%   +7.23%     
==========================================
  Files           7        9       +2     
  Lines         500      591      +91     
==========================================
+ Hits          353      460     +107     
+ Misses         85       77       -8     
+ Partials       62       54       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keroxp keroxp merged commit 8129a1a into main May 29, 2024
5 checks passed
@keroxp keroxp deleted the dev-recreate branch May 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keroxp